Hi,
The first thing I noticed is that the backs of the tone pots are not grounded. You should run a bare wire from each back of the volume pot to the back of the tone pot.
Are the pickups DiMarzios? Then you should wire them as follows:
bridge: red to bridge volume pot input, black and white soldered together and taped, green to ground (= back of bridge volume pot).
neck: red to neck volume pot input, black and white soldered together and taped, green to ground (=back of neck volume pot).
From the middle lug of each volume pot to the toggle switch.
From the toggle switch to the output jack.
Do you have a multimeter? If not, you should get one. They are cheap but invaluable in trouble shooting non-functional guitar wirings.
If you have one, put a guitar cable into the output jack. Set the toggle switch to the middle position and turn all controls up. Then measure the following:
- one probe to the tip of the cable, the other to the middle lug of the bridge pickup. Do you get zero ohms? If yes, fine - the connection between volume pot and jack is fine. If no - there is the trouble. Open the toggle switch control cavity and measure from the bridge volume middle lug to the input of the toggle where the it is connected. Zero ohms = connection is fine, anything else - here is the trouble. Also check between the toggle output and cable tip. Again, zero ohms = fine, anything else = trouble.
Do the same thing with the neck pickup.
- next we check whether there is a ground connection where there should not be one. Measure again from the cable tip but this time hold the other probe against the back of one of the volume pots. You should get the parallel reading of both pickups (appr. 3k to 9k depending on the pickups). Do you get zero? If yes, the signal wire is touching ground somewhere where it should not. Recheck the wiring.
The thing about physics is if something does not work, there is a reason. It's just a matter of finding it.
Good luck,
Stephan